Fix #155 -- allow passing large deposit amounts #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 45fc27e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
aaronmgdr
commented
Feb 27, 2024
| @@ -88,7 +91,7 @@ export default class Propose extends BaseCommand { | |||
| await displaySendTx( | |||
| 'proposeTx', | |||
| governance.propose(proposal, res.flags.descriptionURL), | |||
| { value: deposit.toString() }, | |||
| { value: deposit.toFixed() }, | |||
aaronmgdr
force-pushed
the
aaronmgdr/cli-propose-tests
branch
from
cbf0790 to
45fc27e
Compare
shazarre
approved these changes
Feb 27, 2024
|
|
||
| const expConfig = NetworkConfig.governance | ||
|
|
||
| testWithGanache('governance:propose cmd', (web3: Web3) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
submitting proposals would fail because
depositBigNumber.toString() will convert to scientific notion string when value is over a certain amount and this is not what evm accepts.Other changes
Change helper text on deposit from Gold to Celo
Tested
Added 4 test cases
Related issues
#155
Backwards compatibility
yes
Documentation
none should be needed