Activate votes from any account

[timmoreton]

Description

New --for parameter and matching plumbing in ContractKit to allow pending votes to be activated from any account, not just from msg.sender.

packages/cli/bin/run.js election:activate --help
Activate pending votes in validator elections to begin earning rewards. To earn rewards as a voter, it is required to activate your pending votes at some point after the end of the epoch in which they were made.

USAGE
  $ celocli election:activate --from <value> [--globalHelp] [--for <value>] [--wait]

FLAGS
  --for=0xc1912fEE45d61C87Cc5EA59DaE31190FFFFf232d   Optional: use this to activate votes for another address
  --from=0xc1912fEE45d61C87Cc5EA59DaE31190FFFFf232d  (required) Address sending transaction (and voter's address if --for not specified)
  --globalHelp                                       View all available global flags
  --wait                                             Wait until all pending votes can be activated

DESCRIPTION
  Activate pending votes in validator elections to begin earning rewards. To earn rewards as a voter, it is required to activate your pending votes at
  some point after the end of the epoch in which they were made.

EXAMPLES
  activate --from 0x4443d0349e8b3075cba511a0a87796597602a0f1

  activate --from 0x4443d0349e8b3075cba511a0a87796597602a0f1 --for 0x5409ed021d9299bf6814279a6a1411a7e866a631

  activate --from 0x4443d0349e8b3075cba511a0a87796597602a0f1 --wait

Other changes

None.

Tested

By activating votes on testnet and mainnet.

Related issues

Note.

Backwards compatibility

Yes. New parameter in ContractKit's ElectionWrapper activate method is optional.

Documentation

Updated CLI docs.

[changeset-bot]

🦋 Changeset detected

Latest commit: 41cccbb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@celo/contractkit	Minor
@celo/celocli	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[aaronmgdr]

This looks good

[aaronmgdr]

@shazarre and i will QA this and then merge

[shazarre]

We tested in on alfajores by voting for a validator and trying to activate using the new --for flag straight away and it worked as expected by giving us following message:

Pending votes not yet activatable. Consider using the --wait flag.

which means it accepted the flag just fine.

After this epoch ends we'll test the activation again.

[aaronmgdr]

testing for this made me realize is not easy to vote with fresh account

• I have a celo EOA and want to vote for a Validator Group via CLI  #142

[shazarre]

We've just tested the second step, works as expected 👍

[arthurgousset]

Thanks for QAing the changes @aaronmgdr and @shazarre ! Appreciate it 💯
Merged the PR.