Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded values for locked validator(group) days and value #451

Closed
aaronmgdr opened this issue Nov 20, 2024 · 0 comments · Fixed by #452
Closed

Remove hardcoded values for locked validator(group) days and value #451

aaronmgdr opened this issue Nov 20, 2024 · 0 comments · Fixed by #452
Assignees
@aaronmgdr
Milestone
5 - Celo MVP Mainnet

Comments

@aaronmgdr
Copy link
Member

several places in the CLI it will say 90 days, 180 days, 60 days etc as the lock duration. instead read the actual duration on chain.

Since the values right now are on static properties they will need to be rewritten and then actual values shown during command execution.
@aaronmgdr aaronmgdr added this to the 5 - Celo MVP Mainnet milestone Nov 20, 2024
@aaronmgdr aaronmgdr self-assigned this Nov 20, 2024
@aaronmgdr aaronmgdr mentioned this issue Nov 20, 2024
Merged
aaronmgdr added a commit that referenced this issue Nov 25, 2024
@aaronmgdr
deprecate flags, use dynamic on chain values, add tests (#452)
2283374 
### Description

* mark flags as deprecated which will be non functional on L2 
* use values from on chain for lock requirements
* test member add/remove and deregister

#### Other changes

add async conditional check to checks 

### Related issues

- Fixes #451

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on introducing deprecation warnings for certain flags,
updating descriptions for commands, and enhancing validation checks
related to validator and validator group deregistration processes.
Additionally, it improves the handling of locked gold requirements.

### Detailed summary
- Deprecated `blsKey` and `blsPop` flags in various commands.
- Updated descriptions in `ValidatorDeregister` and
`ValidatorGroupDeRegister` classes.
- Added `humanizeRequirements` function to format locked gold
requirements.
- Improved validation checks for deregistration based on time periods.
- Enhanced tests for validator group membership and deregistration
processes.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronmgdr aaronmgdr

Labels
None yet
Projects
None yet
Milestone
5 - Celo MVP Mainnet
Development

Successfully merging a pull request may close this issue.

deprecate flags, use dynamic on chain values, add tests celo-org/developer-tooling
1 participant
@aaronmgdr