Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
new global cli flag ledgerLiveMode, and new config derivationPath (#488)
### Description allowing users to set a default base derivation path allows users to continue to use celo path as default but for new user of cli to use eth path. ledger live option makes it easy to for users to use same accounts on ledger live as they use in cli. otherwise ledger live would be the only place to access them which was a bit scary at the worst and inconvenient at best. #### Other changes breaking. refactor newLedgerWalletWithSetup to take an options object as we are passing about 5 params. passing in array of changeIndexes to iterate over while searching for addresses on ledger ### QA try out setting the config, then calling account:new, then using useLedger flag, also try --useLedger with --ledgerLiveMode. ### Related issues fixes #448 <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces enhancements to the handling of derivation paths in the Celo CLI and wallet functionalities, particularly for Ledger devices. It adds new flags, improves documentation, and modifies related interfaces and commands. ### Detailed summary - Added `--ledgerLiveMode` flag to iterate over derivation paths for Ledger. - Introduced `DerivationPath` type in `packages/sdk/base/src/account.ts`. - Updated `config:set` command to support `--derivationPath` option. - Enhanced documentation for derivation paths and CLI commands. - Modified `newLedgerWalletWithSetup` and `LedgerWallet` interfaces to accommodate new options. - Added tests for `--derivationPath` handling in `Set` command. - Updated multiple CLI commands to include `--ledgerLiveMode` and `--derivationPath`. > The following files were skipped due to too many changes: `packages/sdk/wallets/wallet-ledger/src/ledger-wallet.ts`, `packages/cli/src/base-l2.test.ts`, `packages/sdk/wallets/wallet-ledger/src/ledger-wallet.test.ts`, `docs/sdk/wallet-ledger/classes/ledger_wallet.LedgerWallet.md`, `docs/command-line-interface/validator.md`, `docs/command-line-interface/releasecelo.md`, `docs/command-line-interface/governance.md`, `docs/command-line-interface/account.md` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
- Loading branch information