WIP add support for EIP1559 and CIP42 to ContractKit (wallet-base) #10474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
∆ ganache.server option format
…onorepo into soloseng/ganache-upgrade
aaronmgdr
commented
Aug 10, 2023
Comment on lines
+443
to
+448
| export function getSignerFromTx(serializedTransaction: string): string { | ||
| const transactionArray: any[] = RLP.decode(`0x${serializedTransaction.slice(4)}`) | ||
| const signer = getPublicKeyofSignerFromTx(transactionArray) | ||
| const address = publicToAddress(signer) | ||
| return `0x` + address.toString('hex') | ||
| } |
soloseng
reviewed
Aug 11, 2023
There was a problem hiding this comment.
This should not be changed.
It is currently preventing GH action from running.
There was a problem hiding this comment.
yeah when i started i branched off the node 18 branch. im gonna try moving my commits to a new branch off master
|
closed for #10483 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This WIP Change adds eip1559 and cip42 signing / serialization. recovery to Contractkit (actually to wallet-base and wallet-local and celo/connect, as these are were the actions happens)
Other changes
Describe any minor or "drive-by" changes here.
Tested
New and Old tests
Related issues
Backwards compatibility
No. Deprecated Functions related to gasPrice have been removed.
Documentation