Moves frozen gold transfer check after check that transactor balance covers gas #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…balance covers gas
alecps
requested review from
nategraf
and removed request for
timmoreton,
asaj and
nategraf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The frozen gold transfer check in validateTx() of tx_pool queries smart contracts for the isFrozen boolean and address whitelist. Currently, this check occurs before ensuring the transactor's balance covers the gas cost. @nategraf pointed out that this might open up a potential denial of service vector, as someone could send many transactions attempting to transfer gold without actually having the requisite gas, each of which would trigger these relatively slow reads from layer 2. This PR addresses this concern by simply rearranging the order of the checks.
Tested
Tests for gold transfer freezing already exist in e2e transfer_tests in celo-monorepo.
Other changes
None.
Related issues
Backwards compatibility
Yes.