Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if epoch rewards are frozen and avoid putting errors in the logs #839

Merged
merged 16 commits into from
Mar 7, 2020

Conversation

nategraf
Copy link
Contributor

Description

Various folks have been asking about the "EVM execution reverted" errors in their logs that come form the epoch rewards being frozen. This PR checks if rewards are frozen and continues without error if so.

Tested

End-to-end tests

Other changes

  • Normalize the gas limit notations in protocol params

Backwards compatibility

Compatible with the contracts after freezing is added

@nategraf nategraf marked this pull request as ready for review January 31, 2020 00:34
@nategraf nategraf requested a review from asaj as a code owner January 31, 2020 00:34
@nategraf nategraf requested a review from timmoreton January 31, 2020 00:34
@nategraf nategraf removed the request for review from asaj January 31, 2020 00:34
@alecps alecps self-requested a review March 7, 2020 00:17
Copy link
Contributor

@alecps alecps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Victor Graf added 2 commits March 6, 2020 17:07
@celo-ci-bot-user celo-ci-bot-user merged commit ffa8d5e into master Mar 7, 2020
@celo-ci-bot-user celo-ci-bot-user deleted the victor/check-rewards-frozen branch March 7, 2020 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants