Bump go version to 1.19 #2189
Merged
Bump go version to 1.19 #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbandura
force-pushed
the
hbandura/go19
branch
from
e7ce2ac
to
9864313
Compare
|
Coverage from tests in coverage: 50.3% of statements across all listed packagescoverage: 63.2% of statements in consensus/istanbul coverage: 42.9% of statements in consensus/istanbul/announce coverage: 55.8% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 63.1% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.2% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
|
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2189 +/- ##
==========================================
+ Coverage 55.09% 55.12% +0.03%
==========================================
Files 681 681
Lines 114407 114405 -2
==========================================
+ Hits 63032 63068 +36
+ Misses 47495 47452 -43
- Partials 3880 3885 +5
☔ View full report in Codecov by Sentry. |
karlb
approved these changes
Sep 25, 2023
carterqw2
requested changes
Sep 25, 2023
carterqw2
approved these changes
Sep 27, 2023
This changes the CI / release builds to use the latest Go version. It also upgrades golangci-lint to a newer version compatible with Go 1.19. In Go 1.19, godoc has gained official support for links and lists. The syntax for code blocks in doc comments has changed and now requires a leading tab character. gofmt adapts comments to the new syntax automatically, so there are a lot of comment re-formatting changes in this PR. We need to apply the new format in order to pass the CI lint stage with Go 1.19. With the linter upgrade, I have decided to disable 'gosec' - it produces too many false-positive warnings. The 'deadcode' and 'varcheck' linters have also been removed because golangci-lint warns about them being unmaintained. 'unused' provides similar coverage and we already have it enabled, so we don't lose much with this change.
hbandura
force-pushed
the
hbandura/go19
branch
from
9bcbbe3
to
eb32682
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream cherry pick of go19 build & Dockerfile bump. A godoc whitespace change in go19 provoked many changes in the code.