Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mycelo election's validators max, at least env validators #2166

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

gastonponti
Copy link
Contributor

Description

Allow mycelo to have more than 100 validators. Keep it as max(100, numValidatorsFromEnv) which is useful for adding validators elected via test, for smaller testnets

@github-actions
Copy link

github-actions bot commented Jul 26, 2023

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit fc20d69

coverage: 49.7% of statements across all listed packages
coverage:  63.2% of statements in consensus/istanbul
coverage:  43.3% of statements in consensus/istanbul/announce
coverage:  55.8% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  60.9% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random

@github-actions
Copy link

5856 passed, 45 skipped

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (84ca735) 55.17% compared to head (d185fad) 55.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2166      +/-   ##
==========================================
+ Coverage   55.17%   55.18%   +0.01%     
==========================================
  Files         676      676              
  Lines      113991   113991              
==========================================
+ Hits        62891    62903      +12     
+ Misses      47233    47213      -20     
- Partials     3867     3875       +8     

see 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gastonponti gastonponti merged commit fc20d69 into master Jul 26, 2023
@gastonponti gastonponti deleted the gastonponti/mycelo-validators-election branch July 26, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants