-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add baseFeePerGas to headers sent via EthSubscribe #2060
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it easier to test websocket specific operations (e.g. subscriptions) and I don't see a reason not to turn in on.
|
Coverage from tests in coverage: 49.3% of statements across all listed packagescoverage: 61.6% of statements in consensus/istanbul coverage: 37.5% of statements in consensus/istanbul/announce coverage: 54.5% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 64.9% of statements in consensus/istanbul/core coverage: 45.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.4% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
karlb
force-pushed
the
karlb/basefee-in-header-subs
branch
from
April 4, 2023 16:03
49c9279
to
a0731a2
Compare
Looks good to me, as a temporary measure until we add it to the header. But let's have @gastonponti have a look as well. |
gastonponti
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
palango
pushed a commit
that referenced
this pull request
Apr 13, 2023
* mycelo: enable websockets Makes it easier to test websocket specific operations (e.g. subscriptions) and I don't see a reason not to turn in on. * Add baseFeePerGas to headers via EthSubscribe Closes celo-org/celo-blockchain-planning#59
palango
pushed a commit
that referenced
this pull request
Apr 13, 2023
* mycelo: enable websockets Makes it easier to test websocket specific operations (e.g. subscriptions) and I don't see a reason not to turn in on. * Add baseFeePerGas to headers via EthSubscribe Closes celo-org/celo-blockchain-planning#59
Merged
gastonponti
pushed a commit
that referenced
this pull request
Apr 17, 2023
* mycelo: enable websockets Makes it easier to test websocket specific operations (e.g. subscriptions) and I don't see a reason not to turn in on. * Add baseFeePerGas to headers via EthSubscribe Closes celo-org/celo-blockchain-planning#59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the
baseFeePerGas
to blocks returned byEthSubscribe
makes the results more consistent with the data returned on Ethereum and via other RPC-Endpoints on Celo. And it is useful!Once we add the
baseFeePerGas
to the header, this implementation is not needed anymore. So this change is only temporary.I did not check for
RPCEthCompatibility
since this is not done forbaseFeePerGas
in the normal JSON-RPC responses, either.Other changes
Tested
Tested against mycelo with the following code
Related issues
Backwards compatibility
Adding a field to the response should not break sanely implemented consumers. IMO it is acceptable to consider this backwards compatible, although it is not true in a strict sense.