Remove istanbul.v1 code #1999
Remove istanbul.v1 code #1999
Conversation
hbandura
requested review from
mcortesi and
nategraf
and removed request for
a team
hbandura
force-pushed
the
hbandura/remv1
branch
from
fb04602
to
0fdd41b
Compare
|
Coverage from tests in coverage: 51.1% of statements across all listed packagescoverage: 63.4% of statements in consensus/istanbul coverage: 42.9% of statements in consensus/istanbul/announce coverage: 56.1% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 66.9% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.4% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/randomCommentID: 3146592755 |
|
@hbandura Have you thought about removing all |
I have, but since we are already retaining the old msg codes (though deprecating them), I thought of just leaving the 'v2', making it explicit that this is a new version of the consensus code. If we were to remove that suffix, I'd still do it in a different PR since I'd like to avoid the mess in the pr diff. |
hbandura
force-pushed
the
hbandura/remv1
branch
from
67d4476
to
21cdcd8
Compare
What do you mean with retaining the old message codes?
Sounds reasonable to me. |
hbandura
force-pushed
the
hbandura/remv1
branch
from
21cdcd8
to
7ca1e8c
Compare
The istanbul msg codes, PreprepareV1 and RoundChangeV1 . I left them with a prepended 'deprecated' in the name. I'm not against removing all references to v2, but I'd rather be sure that at least all validators are running versions that already removed all v1 code. |
hbandura
force-pushed
the
hbandura/remv1
branch
from
e2208a5
to
8c1306e
Compare
hbandura
force-pushed
the
hbandura/remv1
branch
from
8c1306e
to
d987e6d
Compare
| @@ -238,7 +223,7 @@ func (c *core) handleRoundChangeV2(msg *istanbul.Message) error { | |||
| // ---------------------------------------------------------------------------- | |||
|
|
|||
| // CurrentRoundChangeSet returns the current round change set summary. | |||
| func (c *core) CurrentRoundChangeSetV2() *RoundChangeSetSummary { | |||
| func (c *core) CurrentRoundChangeSet() *RoundChangeSetSummary { | |||
There was a problem hiding this comment.
You've been maintaining the V2 suffix in all the PR except this one. Just checking if that was on purpose or not
There was a problem hiding this comment.
It was. Since the CRCS was used from an api call, and we had to check which one to return based on the block, both were available. Now that only one should be there, I decided to change this one now.
hbandura
force-pushed
the
hbandura/remv1
branch
from
d987e6d
to
2fb16cf
Compare
hbandura
force-pushed
the
hbandura/remv1
branch
from
2fb16cf
to
7f6fe11
Compare
* Remove v1 types * Add backlog tests (remove v1) * Remove v1 references from istanbul core core.go * Remove v1 code from handler & handler_test * remove v1 code from preprepare files * remove v1 code from roundchange files * Remove most of v1 code * Remove isConsensusFork * Remove all mentions to V2Block * Remove useless testing suite function
* Remove v1 types * Add backlog tests (remove v1) * Remove v1 references from istanbul core core.go * Remove v1 code from handler & handler_test * remove v1 code from preprepare files * remove v1 code from roundchange files * Remove most of v1 code * Remove isConsensusFork * Remove all mentions to V2Block * Remove useless testing suite function
Remove all code and references of the deprecated istanbul v1 consensus code. The only remnant is the v1 PreparedCertificate since it's still used in storage.