Upstream merge up to 1.9.19

[gastonponti]

Description

Merge from upstream, go-ethereum v 1.9.19 (https://github.com/ethereum/go-ethereum/releases/tag/v1.9.19)

"Geth v1.9.19 is our regular biweekly maintenance release. Apart from the numerous bug-fixes however, it also ships a more deterministic transaction sort order during mining (FIFO). The goal is to reduce front-runner spam which abused miner randomness for transactions at the same price level."

"Note, if you were using GraphQL previously, it was moved to the HTTP RPC endpoint. The old --graphql.host and --graphql.port flags will not work any more. You might need to adjust your TOML config files accordingly too."

1.9.19 Notes:
Deprecated flags:

• GraphQLListenAddrFlag
• GraphQLPortFlag

Added flags:

• CacheTrieJournalFlag
• CacheTrieRejournalFlag

28c5a8a

• fetcher
  • mainLoop
    • check ancestor, otherwise the lightest sync could panic

        if ancestor == nil {
          log.Error("Common ancestor of origin header and current header is nil", "origin hash", origin.Hash(), "current header hash", head.Hash())
          continue
        }
      

    • f.chain.Rollback(untrusted) -> f.chain.Rollback(untrusted, f.handler.syncMode.SyncFullHeaderChain())
  • newLightFetcher
    • return chain.InsertHeaderChain(headers, checkFreq) ->

          i, err := chain.InsertHeaderChain(headers, checkFreq, syncMode.SyncFullHeaderChain())
          if err == consensus.ErrFutureBlock {
            return i, nil
          }
          return i, err
      

      • Add downloader.SyncMode as parameter

b2b14e6

• re-add the changes in our shared extract

c0c0161 (ethereum/go-ethereum#21105)

• node.go:
  • startNetworking should server stop if proxyServer failed? (Added)
• main.go
  • startNode runnerFactory replaced

90dedea

• this commit tried to fusion the consensus/istanbul/core/event.go file with an erased tests (signed_data_internal_test.go)
  I've restored that test, and add the changes from the signer/core/signed_data.go, to the shared/signer/signed_data.go

c28fd9c

• make Berlin a copy of Istanbul instead of YoloV1

Tested

Unit and integration tests pass

Related issues

• Fixes Merge upstream 1.9.19 #1326

Backwards compatibility

The commit c0c0161 (ethereum/go-ethereum#21105) "changes the APIs for instantiating Ethereum nodes in a Go program. The new APIs are not backwards-compatible" (following this proposal https://gist.github.com/renaynay/5bec2de19fde66f4d04c535fd24f0775)

[codecov]

Codecov Report

Merging #1615 (290c14d) into master (968e504) will increase coverage by 0.45%.
The diff coverage is 56.56%.

@@            Coverage Diff             @@
##           master    #1615      +/-   ##
==========================================
+ Coverage   55.61%   56.06%   +0.45%     
==========================================
  Files         607      606       -1     
  Lines       80211    80267      +56     
==========================================
+ Hits        44609    45005     +396     
+ Misses      32107    31726     -381     
- Partials     3495     3536      +41     

Impacted Files	Coverage Δ
cmd/devp2p/enrcmd.go	0.00% <0.00%> (ø)
cmd/geth/chaincmd.go	0.00% <0.00%> (ø)
cmd/geth/config.go	0.00% <0.00%> (ø)
cmd/geth/consolecmd.go	0.00% <0.00%> (ø)
cmd/geth/main.go	19.64% <0.00%> (+1.70%)	⬆️
cmd/geth/usage.go	7.69% <ø> (ø)
cmd/utils/cmd.go	0.00% <0.00%> (ø)
cmd/utils/flags.go	2.87% <0.00%> (+0.06%)	⬆️
cmd/utils/flags_legacy.go	0.00% <ø> (ø)
core/genesis.go	64.20% <0.00%> (ø)
... and 96 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 968e504...290c14d. Read the comment docs.