Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds new metrics for discovery #1129

Merged
merged 6 commits into from
Aug 6, 2020
Merged

Adds new metrics for discovery #1129

merged 6 commits into from
Aug 6, 2020

Conversation

mcortesi
Copy link
Contributor

@mcortesi mcortesi commented Aug 6, 2020

Description

Adds new metrics to the existing ones; with the objective of better understanding discovery.

# Total number of discovered nodes by the les client
les_client_discovered
# Total number of inbound bytes for discovery v4
discover_ingress
# Total number of outbound bytes for discovery v4
discover_egress
# Total number of successful connections with valid handshakes (inbound)
p2p_serves_handshakes
# Total number of successful connections with valid handshakes (outbound)
p2p_dials_handshakes

Other changes

No

Tested

CI

Related issues

  • Fixes #[issue number here]

Backwards compatibility

Yes

@mcortesi mcortesi requested review from asaj and tkporter August 6, 2020 17:58
tkporter
tkporter approved these changes Aug 6, 2020
View reviewed changes
p2p/metrics.go Outdated Show resolved Hide resolved
nategraf
nategraf approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@nategraf nategraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be helpful! I left a couple of comments related to our discussion yesterday.

p2p/discover/metrics.go Show resolved Hide resolved
les/serverpool.go Show resolved Hide resolved
les/metrics.go Show resolved Hide resolved
@mcortesi mcortesi changed the title Add more metrics for discovery Adds new metrics for discovery Aug 6, 2020
@mcortesi mcortesi merged commit fd05c6b into master Aug 6, 2020
@mcortesi mcortesi deleted the mc/discover-metrics branch August 6, 2020 20:34
@mcortesi mcortesi added this to the 1.0.2 milestone Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nategraf nategraf nategraf approved these changes

@tkporter tkporter tkporter approved these changes

@kevjue kevjue Awaiting requested review from kevjue

@asaj asaj Awaiting requested review from asaj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mcortesi @nategraf @tkporter