Add peer connection metrics by peer purpose #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make it immutable, thus easier to track * Use `Add` , `Remove` vs `Set(bool)` * Peer now has a single purpose which is the combination of trustedPurposes & staticPurposes
tkporter
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add number of active (connected) peers metrics discriminated by purpose (validator & proxy).
With this, we should be able to monitor how many validator or proxy connection a node currently has.
Other changes
Refactors PurposeFlag use:
Add,RemovevsSet(bool)trustedPurposes & staticPurposes
Tested
CI, manual
Related issues
Backwards compatibility
Brief explanation of why these changes are/are not backwards compatible.