Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix / Rewrite flaky benchmark BenchmarkNet1000Txs #1852

Open
hbandura opened this issue Feb 18, 2022 · 0 comments
Open

Fix / Rewrite flaky benchmark BenchmarkNet1000Txs #1852

hbandura opened this issue Feb 18, 2022 · 0 comments
Labels
good first issue

Comments

@hbandura
Copy link
Contributor

No description provided.

@hbandura hbandura mentioned this issue Feb 18, 2022
Merged
mergify bot pushed a commit that referenced this issue Feb 18, 2022
@hbandura
Skipping flaky tests (#1848)
c78a51f 
This PR comments/skips tests, builds and benchmarks that are known to be flaky.

Unit tests:
- TestAnnounceGossipQueryMsg #1849
- TestEthClient/TestCallContract #1850
- TestGethClient/TestAccessList #1851

Benchmarks:
- BenchmarkNet1000Txs #1852

Circleci builds:
- end-to-end-cip35-eth-compatibility-test #1853


While creating this PR, the istanbul-e2e-coverage failed once, then worked when it was re-run. I'm not skipping this one right now since I'd like to test it a bit more. Most likely it is because the parent commit has flaky tests, which are run for coverage report.

codecov/project is failing because we are removing a few tests. It is expected.
@carterqw2 carterqw2 added triage Issue needs triaging and removed blockchain labels Feb 9, 2023
@carterqw2 carterqw2 added good first issue and removed triage Issue needs triaging labels Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hbandura @carterqw2