Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

fix: make the orchestrator sign by default #521

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Oct 10, 2023

Overview

Closes #513

This makes the orchestrator signs by default, instead of needing to be part of a valset to sign. The only case it doesn't sign is when it finds a valset and it's not part of it.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id added bug Something isn't working orchestrator orchestrator related labels Oct 10, 2023
@rach-id rach-id self-assigned this Oct 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #521 (bab5373) into main (69e71e8) will increase coverage by 0.10%.
Report is 7 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
+ Coverage   24.38%   24.48%   +0.10%     
==========================================
  Files          29       29              
  Lines        2949     2936      -13     
==========================================
  Hits          719      719              
+ Misses       2144     2131      -13     
  Partials       86       86              
Files Coverage Δ
orchestrator/orchestrator.go 1.94% <0.00%> (+0.07%) ⬆️

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice debugging.

@rach-id rach-id merged commit 2a76b48 into celestiaorg:main Oct 10, 2023
13 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working orchestrator orchestrator related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orchestrator fails when there is only one valset in store
3 participants