Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: gracefully retry da connection err #43

Merged
merged 1 commit into from
May 15, 2023

Conversation

tuxcanfly
Copy link
Collaborator

Overview

This PR allows DataFromEVMTransactions to return a error, so that it can be wrapped in a TemporaryError as a sentinel to signal that there was a temporary connection error to the DA and that the caller must retry the same transactions again.

Fixes #31

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runs as expected for me on this setup :shipit:

@tuxcanfly tuxcanfly merged commit d0280e1 into celestia-develop May 15, 2023
@jcstein jcstein deleted the tux/fix-da-conn-err branch May 16, 2023 02:08
tuxcanfly pushed a commit that referenced this pull request Jan 3, 2024
span-batches: encode bitlists as big-endian integers, use standard Go…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow op-node to retry fetching data at latest height with light node
3 participants