op-node: da-rpc, namespace-id - use environment flags (#158)

* op-node: use global string for da flags * op-node: use flag name * testnet: better healthcheck * testnet: restore rpc flags
celestiaorg · Nov 28, 2023 · ecc4c9b · ecc4c9b
1 parent 998cc21
commit ecc4c9b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/op-node/flags/flags.go b/op-node/flags/flags.go
@@ -290,14 +290,16 @@ var (
 var requiredFlags = []cli.Flag{
 	L1NodeAddr,
 	L2EngineAddr,
+	RPCListenAddr,
+	RPCListenPort,
+	DaRPC,
+	NamespaceId,
 }
 
 var optionalFlags = []cli.Flag{
 	RPCListenAddr,
 	RPCListenPort,
 	RollupConfig,
-	DaRPC,
-	NamespaceId,
 	Network,
 	L1TrustRPC,
 	L1RPCProviderKind,

diff --git a/ops-bedrock/docker-compose-testnet.yml b/ops-bedrock/docker-compose-testnet.yml
@@ -61,6 +61,12 @@ services:
     build:
       context: ../
       dockerfile: ./op-node/Dockerfile
+    healthcheck:
+      test: ["CMD", "wget", "-q", "-O", "-", "http://op-node:8545"]
+      interval: 5s
+      timeout: 5s
+      retries: 5
+      start_period: 10s
     command: >
       op-node
       --l1=ws://l1:8546
@@ -141,7 +147,7 @@ services:
       - "7301:7300"
       - "6545:8545"
     healthcheck:
-      test: ["CMD", "curl", "-f", "http://da:26659/header/1"]
+      test: ["CMD", "wget", "-q", "-O", "-", "http://da:26659/header/1"]
       interval: 5s
       timeout: 5s
       retries: 5