Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add benchmarks to share encoding and decoding #83

Merged
merged 16 commits into from
Jun 24, 2024

Conversation

cmwaters
Copy link
Collaborator

@cmwaters cmwaters commented Jun 19, 2024

Closes: #81

Note: need to also backport this to v1.x

@cmwaters cmwaters self-assigned this Jun 20, 2024
@cmwaters cmwaters marked this pull request as ready for review June 21, 2024 08:36
@cmwaters cmwaters requested review from a team as code owners June 21, 2024 08:36
@cmwaters cmwaters requested review from rootulp, evan-forbes, ramin and Wondertan and removed request for a team June 21, 2024 08:36
@cmwaters cmwaters changed the base branch from cal/v1-shares to main June 21, 2024 08:36
@celestia-bot celestia-bot requested review from a team June 21, 2024 08:37
cristaloleg
cristaloleg previously approved these changes Jun 21, 2024
Copy link
Contributor

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

rootulp
rootulp previously approved these changes Jun 21, 2024
internal/test/factory.go Outdated Show resolved Hide resolved
@cmwaters cmwaters enabled auto-merge (squash) June 24, 2024 07:19
@celestia-bot celestia-bot requested review from a team June 24, 2024 07:19
@cmwaters cmwaters dismissed stale reviews from rootulp and cristaloleg via 0f9ff39 June 24, 2024 07:32
@cmwaters cmwaters merged commit c078e37 into main Jun 24, 2024
11 checks passed
@cmwaters cmwaters deleted the cal/share-benchmarks branch June 24, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add benchmarks to share encoding / decoding
4 participants