Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: utilize go version from go.mod #71

Merged
merged 3 commits into from
Jun 13, 2024
Merged

ci: utilize go version from go.mod #71

merged 3 commits into from
Jun 13, 2024

Conversation

ramin
Copy link
Contributor

@ramin ramin commented Jun 13, 2024

Overview

drive by! was glancing at the namespace PR and saw we could remove the hardcoded GO_VERSION ENV var for loading directly from the go.mod, figured i'd do my part 🫡

@ramin ramin requested review from a team as code owners June 13, 2024 10:09
@ramin ramin requested review from cmwaters, staheri14, walldiss and distractedm1nd and removed request for a team June 13, 2024 10:09
@celestia-bot celestia-bot requested review from a team June 13, 2024 10:09
cristaloleg
cristaloleg approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Didn't know ./go.mod syntax.

cmwaters
cmwaters approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@cmwaters cmwaters left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I didn't realise you could do that, thanks!

@ramin ramin merged commit f281127 into main Jun 13, 2024
12 checks passed
@ramin ramin deleted the ci/ramin/go-version branch June 13, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmwaters cmwaters cmwaters approved these changes

@cristaloleg cristaloleg cristaloleg approved these changes

@staheri14 staheri14 Awaiting requested review from staheri14 staheri14 is a code owner automatically assigned from celestiaorg/celestia-core

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner automatically assigned from celestiaorg/celestia-node

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd distractedm1nd is a code owner automatically assigned from celestiaorg/celestia-node

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramin @cristaloleg @cmwaters