-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add fuzzers for Builder.Export + inclusion.SubtreeWidth #119
base: main
Are you sure you want to change the base?
test: add fuzzers for Builder.Export + inclusion.SubtreeWidth #119
Conversation
f6c0845
to
d6f4e64
Compare
golangci-lint is failing: https://github.com/celestiaorg/go-square/actions/runs/11416803480/job/31768417818?pr=119#step:5:37 cc: @odeke-em |
@rootulp thanks for the ping but I think that your repo's helpers are giving y'all bad tips and invalid suggestions fuzz_test.go:15: File is not `gofumpt`-ed (gofumpt)
33
if err := os.MkdirAll(dirPath, 0755); err != nil { is idiomatic code and the preferred way for quick throw away values in Go. I am going to change it but I highly suggest in the future taking a look at the suggestions. |
9fe938f
to
9c9f5c6
Compare
|
Thank you @cristaloleg! Sadly the CI suggestion did not appear in the error log. Let me update that. |
For the record, even that suggestion is pedantic per https://go.dev/play/p/CpKnMA6OAKj but let me push up the suggestion still. |
In a continuous bid to battle test and secure the network, this change adds 2 fuzzers for: * Builder.Export * inclusion.SubtreeWidth
9c9f5c6
to
f2a86d1
Compare
@cristaloleg we have a panic uncovered in 2 minutes of fuzzing per #120. Kindly please help define what happens so that this change can then be merged. Thank you! |
Maybe pedantic but definitely error-prone. |
@odeke-em do you have a concrete suggestion on what linter settings you would like to be changed for this repo? https://golangci-lint.run/usage/linters/#gofumpt doesn't have a setting to disable just this rule: so we would need to disable gofumpt entirely which doesn't seem desirable. Additionally, that specific lint rule seems like a good suggestion so I propose we keep gofumpt and modify the code to satisfy the linter. |
In a continuous bid to battle test and secure the network, this change adds 2 fuzzers for: