Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add missing utilities used by celestia-node #109

Merged
merged 15 commits into from
Oct 17, 2024
Merged

feat: add missing utilities used by celestia-node #109

merged 15 commits into from
Oct 17, 2024

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Oct 7, 2024

Overview

Added missing functionality that is commonly used by the node team.

@vgonkivs vgonkivs self-assigned this Oct 7, 2024
@vgonkivs vgonkivs requested review from a team as code owners October 7, 2024 12:33
@vgonkivs vgonkivs requested review from evan-forbes and cristaloleg and removed request for a team October 7, 2024 12:33
@celestia-bot celestia-bot requested review from a team October 7, 2024 12:33
cristaloleg
cristaloleg reviewed Oct 7, 2024
View reviewed changes
share/share_test.go Outdated Show resolved Hide resolved
share/blob.go Outdated Show resolved Hide resolved
rootulp
rootulp reviewed Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking but I have a few questions before approving.

share/namespace.go Outdated Show resolved Hide resolved
share/namespace.go Outdated Show resolved Hide resolved
share/random_namespace.go Outdated Show resolved Hide resolved
share/random_shares.go Outdated Show resolved Hide resolved
share/random_shares.go Outdated Show resolved Hide resolved
@vgonkivs @rootulp @cristaloleg
apply suggestions
fa5e214 
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Oleg Kovalov <[email protected]>
@celestia-bot celestia-bot requested review from a team and cristaloleg and removed request for a team October 14, 2024 09:25
@vgonkivs vgonkivs requested a review from rootulp October 14, 2024 10:33
Wondertan
Wondertan reviewed Oct 14, 2024
View reviewed changes
share/blob.go Outdated Show resolved Hide resolved
share/namespace.go Show resolved Hide resolved
share/namespace.go Outdated Show resolved Hide resolved
share/share.go Show resolved Hide resolved
share/share.go Outdated Show resolved Hide resolved
@Wondertan Wondertan mentioned this pull request Oct 14, 2024
Merged
@celestia-bot celestia-bot requested review from a team and walldiss and removed request for a team October 15, 2024 14:09
rootulp
rootulp previously approved these changes Oct 16, 2024
View reviewed changes
@vgonkivs vgonkivs dismissed stale reviews from rootulp and walldiss via e7b37c2 October 16, 2024 15:24
@celestia-bot celestia-bot requested review from a team October 16, 2024 15:24
renaynay
renaynay previously approved these changes Oct 16, 2024
View reviewed changes
share/namespace.go Outdated Show resolved Hide resolved
@celestia-bot celestia-bot requested a review from a team October 16, 2024 16:07
@vgonkivs @renaynay
apply suggestion
96d28f7 
Co-authored-by: rene <[email protected]>
rootulp
rootulp previously approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM. Super optional but the PR title could be renamed to something more informative. Example: "feat: add missing utilities used by celestia-node"

share/namespace.go Outdated Show resolved Hide resolved
@vgonkivs vgonkivs changed the title feat: add missed functionality feat: add missing utilities used by celestia-node Oct 17, 2024
cmwaters
cmwaters requested changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just get the validity rules for these methods right and then this seems good to merge

share/namespace.go Outdated Show resolved Hide resolved
share/namespace.go Show resolved Hide resolved
share/namespace.go Outdated Show resolved Hide resolved
@vgonkivs @rootulp
apply suggestion
7ad5bcf 
Co-authored-by: Rootul P <[email protected]>
@celestia-bot celestia-bot requested review from a team and staheri14 and removed request for a team October 17, 2024 11:44
@celestia-bot celestia-bot requested a review from a team October 17, 2024 12:56
Wondertan
Wondertan approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

share/namespace.go Show resolved Hide resolved
cmwaters
cmwaters approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@vgonkivs vgonkivs merged commit f47b641 into celestiaorg:main Oct 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmwaters cmwaters cmwaters approved these changes

@Wondertan Wondertan Wondertan approved these changes

@evan-forbes evan-forbes Awaiting requested review from evan-forbes evan-forbes is a code owner automatically assigned from celestiaorg/celestia-core

@cristaloleg cristaloleg Awaiting requested review from cristaloleg cristaloleg is a code owner automatically assigned from celestiaorg/celestia-node

@walldiss walldiss Awaiting requested review from walldiss

@renaynay renaynay Awaiting requested review from renaynay

@staheri14 staheri14 Awaiting requested review from staheri14 staheri14 is a code owner automatically assigned from celestiaorg/celestia-core

@rootulp rootulp Awaiting requested review from rootulp

Assignees

@vgonkivs vgonkivs

Labels
external
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vgonkivs @cristaloleg @rootulp @walldiss @Wondertan @cmwaters @renaynay