-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: harden verification #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 68.27% 68.41% +0.14%
==========================================
Files 37 37
Lines 2909 2929 +20
==========================================
+ Hits 1986 2004 +18
- Misses 771 774 +3
+ Partials 152 151 -1
|
Wondertan
commented
Jul 31, 2023
Wondertan
force-pushed
the
call-validate
branch
2 times, most recently
from
August 15, 2023 13:43
e81c0c1
to
9e29211
Compare
Wondertan
force-pushed
the
verify
branch
2 times, most recently
from
August 20, 2023 09:58
b8065f9
to
bdda7bd
Compare
Wondertan
requested review from
tzdybal,
renaynay,
vgonkivs and
gupadhyaya
as code owners
August 21, 2023 11:59
Wondertan
changed the title
refactor: harden verification
refactor!: harden verification
Aug 21, 2023
vgonkivs
previously approved these changes
Aug 22, 2023
renaynay
reviewed
Aug 22, 2023
vgonkivs
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
renaynay
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We realized that non-adjacent verification might produce false negatives in Tendermint consensus. Additionally, not all chains have non-adjacent verification, and before this change, we dropped all headers that failed the non-adjacency verification. However, we should give them a second chance and keep them as sync targets.
Additionally:
Closes #79