test(sync): Test case where bad header is set as sync target #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
force-pushed
the
sync-test-attack
branch
from
2e9aabb
to
f8e4fb4
Compare
renaynay
requested review from
tzdybal,
Wondertan,
vgonkivs and
gupadhyaya
as code owners
tzdybal
reviewed
Jul 11, 2023
tzdybal
reviewed
Jul 11, 2023
|
Okay the test is flakey - i need to convert to draft |
github-merge-queue bot
pushed a commit
to celestiaorg/celestia-node
that referenced
this pull request
Jul 11, 2023
This PR disables skipping verification and accepts all the incoming non-adjacent headers. These headers will later be verified via adjacent verification and rejected if invalid. Test that proves that Syncer rejects and continues to work with a fault header: celestiaorg/go-header#76 Potential outcomes of doing so: celestiaorg/go-header#79 Additionally, the PR reverts the genesis hash change to the hash pointing to height 1. Supersedes #2449, which became zombie --------- Co-authored-by: rene <[email protected]>
github-merge-queue bot
pushed a commit
to celestiaorg/celestia-node
that referenced
this pull request
Jul 12, 2023
This PR disables skipping verification and accepts all the incoming non-adjacent headers. These headers will later be verified via adjacent verification and rejected if invalid. Test that proves that Syncer rejects and continues to work with a fault header: celestiaorg/go-header#76 Potential outcomes of doing so: celestiaorg/go-header#79 Additionally, the PR reverts the genesis hash change to the hash pointing to height 1. Supersedes #2449, which became zombie --------- Co-authored-by: rene <[email protected]>
vgonkivs
approved these changes
Jul 14, 2023
0semter0
pushed a commit
to 0semter0/celestia-node
that referenced
this pull request
Aug 12, 2024
This PR disables skipping verification and accepts all the incoming non-adjacent headers. These headers will later be verified via adjacent verification and rejected if invalid. Test that proves that Syncer rejects and continues to work with a fault header: celestiaorg/go-header#76 Potential outcomes of doing so: celestiaorg/go-header#79 Additionally, the PR reverts the genesis hash change to the hash pointing to height 1. Supersedes #2449, which became zombie --------- Co-authored-by: rene <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement test for the case where a bad header is set as a sync target and ensure that syncer can discard and recover from it.