-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(p2p)!: Extend Head interface's Head method with ...HeadOption, introduce WithTrustedHead opt #53
Conversation
Codecov Report
@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 67.27% 68.21% +0.93%
==========================================
Files 35 36 +1
Lines 2827 2888 +61
==========================================
+ Hits 1902 1970 +68
+ Misses 772 766 -6
+ Partials 153 152 -1
|
b220d7a
to
1c3b8a9
Compare
The merge-base changed after approval.
1c3b8a9
to
33ff9b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Updated title + description |
…block" on attempts to connect to bootstrappers and spawn async attempts for all peers in pidstore
…rs, no more waitForPeers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last nits and GTG
This PR introduces variadic
HeadOptions
and adds them as optional param to the Head method in theHead
interface.It will allow callers to the Exchange's
Head
method to specify if subjective initialisation is required, determining which peerset (trusted or tracked) to choose from (the default is tracked) via theWithTrustedHead
option.It also exposes a getPeers endpoint on the tracker that returns its currently tracked peers.