Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store): add tail header #199

Closed
wants to merge 1 commit into from
Closed

feat(store): add tail header #199

wants to merge 1 commit into from

Conversation

cristaloleg
Copy link
Contributor

Overview

Add tailHeader as a part of backward sync. Currently it's initialized to initial header and isn't exported. Harmless addition to simplify future PRs.

Wondertan
Wondertan requested changes Jun 20, 2024
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we want to add half-baked features into the main. We have never done this before, and I don't see any reason to. If you want to move with PRs that are that small, I propose to have a feature branch for backward sync

@cristaloleg
Copy link
Contributor Author

Sad to hear that but ok. We've discussed this in DM but I don't want to continue.

@cristaloleg cristaloleg deleted the store/add-tail-header branch June 20, 2024 11:43
@Wondertan
Copy link
Member

@cristaloleg, I don't recall discussing this in DM; could you point to that? Also, why not make a feature branch?

@cristaloleg
Copy link
Contributor Author

Will happen in #200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan requested changes

@tzdybal tzdybal Awaiting requested review from tzdybal tzdybal is a code owner

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@gupadhyaya gupadhyaya Awaiting requested review from gupadhyaya gupadhyaya is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

@ramin ramin Awaiting requested review from ramin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristaloleg @Wondertan