Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: make Header.Height uint64 #100

Merged
merged 1 commit into from
Aug 25, 2023
Merged

refactor!: make Header.Height uint64 #100

merged 1 commit into from
Aug 25, 2023

Conversation

Wondertan
Copy link
Member

Closes #39
Based on #96

@Wondertan Wondertan self-assigned this Aug 24, 2023
Base automatically changed from type-paramed-header to main August 25, 2023 09:39
@Wondertan Wondertan marked this pull request as ready for review August 25, 2023 09:45
renaynay
renaynay approved these changes Aug 25, 2023
View reviewed changes
headertest/dummy_header.go Show resolved Hide resolved
p2p/server.go Show resolved Hide resolved
@Wondertan Wondertan enabled auto-merge (squash) August 25, 2023 14:19
@Wondertan Wondertan merged commit 2fd3b1b into main Aug 25, 2023
2 checks passed
@Wondertan Wondertan deleted the uint-height branch August 25, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@distractedm1nd distractedm1nd distractedm1nd approved these changes

@renaynay renaynay renaynay approved these changes

@tzdybal tzdybal Awaiting requested review from tzdybal tzdybal is a code owner

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@gupadhyaya gupadhyaya Awaiting requested review from gupadhyaya gupadhyaya is a code owner

Assignees

@Wondertan Wondertan

Labels
kind:break! kind:refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header.Height should be uint64
3 participants
@Wondertan @distractedm1nd @renaynay