Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: add gateway deprecated flag #851

Merged
merged 1 commit into from
Jun 30, 2023
Merged

deps: add gateway deprecated flag #851

merged 1 commit into from
Jun 30, 2023

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Jun 29, 2023

Overview

This is meant to be merged once Mocha and Arabica are upgraded.

This PR adds the --gateway.deprecated-endpoints flag in alignment with celestiaorg/celestia-node#2360. This is meant to not break existing functionality for developers or users, including Rollkit tutorials which I have opened an issue for rollkit/docs#189. I also opened an issue on docs to #850 follow up with guidance on the deprecation

Resolves #849

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-06-30 20:06 UTC

@jcstein jcstein requested review from a team, distractedm1nd, Wondertan and YazzyYaz and removed request for a team June 29, 2023 13:35
@jcstein jcstein self-assigned this Jun 29, 2023
@jcstein jcstein marked this pull request as ready for review June 29, 2023 14:20
@YazzyYaz YazzyYaz merged commit 66c5791 into main Jun 30, 2023
@YazzyYaz YazzyYaz deleted the jcs/issue-849 branch June 30, 2023 20:03
jcstein pushed a commit that referenced this pull request Sep 21, 2023
deps: add gateway deprecated flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

match #2360 on celestia-node
2 participants