Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(share/availability): propagate errors from light availability properly #3888

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

walldiss
Copy link
Member

  • Fix ctx canceled error being returned before sampling result is persisted.
  • Store Put error should be propagated to the caller, to allow retry of sampling for the same height.

@walldiss walldiss added the kind:fix Attached to bug-fixing PRs label Oct 28, 2024
@walldiss walldiss self-assigned this Oct 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 45.20%. Comparing base (2469e7a) to head (413ffdc).
Report is 364 commits behind head on main.

Files with missing lines Patch % Lines
share/availability/light/availability.go 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3888      +/-   ##
==========================================
+ Coverage   44.83%   45.20%   +0.37%     
==========================================
  Files         265      310      +45     
  Lines       14620    21873    +7253     
==========================================
+ Hits         6555     9888    +3333     
- Misses       7313    10924    +3611     
- Partials      752     1061     +309     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@walldiss walldiss enabled auto-merge (squash) October 28, 2024 20:19
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree w hlib re log, otherwise gtg

@walldiss walldiss enabled auto-merge (squash) October 29, 2024 15:12
@walldiss walldiss merged commit c913b13 into celestiaorg:main Oct 29, 2024
32 checks passed
@Wondertan Wondertan deleted the light-avail-errors branch October 29, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants