-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core/listener): wait listener to shutdown before exit #3775
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3775 +/- ##
==========================================
+ Coverage 44.83% 46.50% +1.67%
==========================================
Files 265 314 +49
Lines 14620 17999 +3379
==========================================
+ Hits 6555 8371 +1816
- Misses 7313 8609 +1296
- Partials 752 1019 +267 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please explain how it fixes the flake either in the comment or PR description for future ref
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Set chan to nil when done ? And make chan on start ?
Previously we observed panic with
leveldb: closed
in integration tests. It was caused by core.listener accessing already closed core block generator. The reason for it could be leaked listener subscriber routine after node is closed, that was trying to access generator.The PR introduces graceful shutdown for listener, that will wait for spawned routines to stop before exiting.