Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: bump celestia-app to v2.1.2 #3674

Merged
merged 12 commits into from
Aug 29, 2024

Conversation

ninabarbakadze
Copy link
Member

@ninabarbakadze ninabarbakadze commented Aug 22, 2024

Description

  • Bumps app to latest v2 release

Breaking changes

  • There was a slight change in the way errors are currently constructed, but nevertheless it still contains the error log which has the error string.
  • We're maintaining the return type of SubmitPayForBlob, but some fields will no longer be populated and will be set to empty for their respective types.

@github-actions github-actions bot added the external Issues created by non node team members label Aug 22, 2024
@ninabarbakadze ninabarbakadze changed the title chore: bump celestia-app to v2.1.0 chore(deps): bump celestia-app to v2.1.0 Aug 22, 2024
@ninabarbakadze ninabarbakadze added the kind:deps Pull requests that update a dependency file label Aug 22, 2024
@ninabarbakadze ninabarbakadze self-assigned this Aug 22, 2024
go.mod Outdated Show resolved Hide resolved
@vgonkivs
Copy link
Member

Linter and Docker build are failing btw

@ninabarbakadze
Copy link
Member Author

ninabarbakadze commented Aug 22, 2024

Linter and Docker build are failing btw

yeah working on it. I'll convert it to draft.

@ninabarbakadze ninabarbakadze marked this pull request as draft August 22, 2024 10:44
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.58%. Comparing base (2469e7a) to head (49c6e6a).
Report is 181 commits behind head on main.

Files with missing lines Patch % Lines
state/core_access.go 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3674      +/-   ##
==========================================
+ Coverage   44.83%   45.58%   +0.74%     
==========================================
  Files         265      281      +16     
  Lines       14620    16035    +1415     
==========================================
+ Hits         6555     7309     +754     
- Misses       7313     7883     +570     
- Partials      752      843      +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@ninabarbakadze ninabarbakadze changed the title chore(deps): bump celestia-app to v2.1.0 chore(deps): bump celestia-app to v2.1.2 Aug 23, 2024
@ninabarbakadze ninabarbakadze marked this pull request as ready for review August 23, 2024 09:48
@walldiss
Copy link
Member

@ninabarbakadze celestia-node is upgraded to 1.23, but it is unfortunately require rebase of this PR.

state/core_access.go Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
@ninabarbakadze ninabarbakadze marked this pull request as draft August 27, 2024 12:20
@ninabarbakadze ninabarbakadze marked this pull request as ready for review August 27, 2024 13:55
state/core_access.go Show resolved Hide resolved
state/core_access.go Show resolved Hide resolved
@ninabarbakadze ninabarbakadze changed the title chore(deps): bump celestia-app to v2.1.2 chore!: bump celestia-app to v2.1.2 Aug 28, 2024
@ninabarbakadze ninabarbakadze added the kind:break! Attached to breaking PRs label Aug 28, 2024
@walldiss
Copy link
Member

After sync with @ninabarbakadze: The changes alters returned value and errors slightly, while preserves all usefull info from previous implementation. Technically breaking, but most likely will not affect anyone. Agreed to mark it as breaking and list the reason in release,.

@walldiss walldiss enabled auto-merge (squash) August 28, 2024 10:53
@walldiss walldiss merged commit 63e5230 into celestiaorg:main Aug 29, 2024
23 of 30 checks passed
@ninabarbakadze ninabarbakadze deleted the nina/bump-app-version branch August 29, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members kind:break! Attached to breaking PRs kind:deps Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants