-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: bump celestia-app to v2.1.2 #3674
chore!: bump celestia-app to v2.1.2 #3674
Conversation
12774dc
to
7256422
Compare
Linter and Docker build are failing btw |
yeah working on it. I'll convert it to draft. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3674 +/- ##
==========================================
+ Coverage 44.83% 45.58% +0.74%
==========================================
Files 265 281 +16
Lines 14620 16035 +1415
==========================================
+ Hits 6555 7309 +754
- Misses 7313 7883 +570
- Partials 752 843 +91 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me
@ninabarbakadze celestia-node is upgraded to 1.23, but it is unfortunately require rebase of this PR. |
Co-authored-by: Rootul P <[email protected]>
3a49397
to
b37ba61
Compare
After sync with @ninabarbakadze: The changes alters returned value and errors slightly, while preserves all usefull info from previous implementation. Technically breaking, but most likely will not affect anyone. Agreed to mark it as breaking and list the reason in release,. |
Description
Breaking changes