Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(nodebuilder): disable TestArchivalBlobSync #3635

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

cristaloleg
Copy link
Contributor

Disable this test for now due to its frequent failures. Will be revisited later.

Copy link
Member

@vgonkivs vgonkivs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create an issue and add it here above t.Skip()?

@cristaloleg
Copy link
Contributor Author

Done #3636

walldiss
walldiss previously approved these changes Aug 8, 2024
@ramin
Copy link
Contributor

ramin commented Aug 8, 2024

@cristaloleg we had wrapped these skips in testing.Short() before so they don't vanish completely, and CI can be run with the short flag (assuming its some resource/bootstrap constraint in ci env) but locally they still run, might be worth doing similar

eg: https://github.com/celestiaorg/celestia-node/blob/main/nodebuilder/tests/reconstruct_test.go#L89

@renaynay renaynay enabled auto-merge (squash) October 2, 2024 13:33
@renaynay renaynay merged commit 09ba75c into main Oct 2, 2024
27 checks passed
@renaynay renaynay deleted the nodebuilder/disable-TestArchivalBlobSync branch October 2, 2024 14:29
renaynay pushed a commit to renaynay/celestia-node that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:testing Related to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants