fix(ci/release): golreleaser pre-release behavior #3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramin
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
walldiss and
cristaloleg
as code owners
Wondertan
approved these changes
Jul 17, 2024
rootulp
added a commit
to rootulp/celestia-app
that referenced
this pull request
Jul 17, 2024
There is an issue with goreleaser where it would automatically mark release candidates as the latest release. Motivated by celestiaorg/celestia-node#3569
evan-forbes
pushed a commit
to celestiaorg/celestia-app
that referenced
this pull request
Jul 18, 2024
There is an issue with goreleaser where it will automatically mark release candidates as the latest release. Motivated by celestiaorg/celestia-node#3569 Thanks @ramin!
mergify bot
pushed a commit
to celestiaorg/celestia-app
that referenced
this pull request
Jul 18, 2024
There is an issue with goreleaser where it will automatically mark release candidates as the latest release. Motivated by celestiaorg/celestia-node#3569 Thanks @ramin! (cherry picked from commit 99d9def)
mergify bot
pushed a commit
to celestiaorg/celestia-app
that referenced
this pull request
Jul 18, 2024
There is an issue with goreleaser where it will automatically mark release candidates as the latest release. Motivated by celestiaorg/celestia-node#3569 Thanks @ramin! (cherry picked from commit 99d9def)
rootulp
added a commit
to celestiaorg/celestia-app
that referenced
this pull request
Jul 18, 2024
…3702) There is an issue with goreleaser where it will automatically mark release candidates as the latest release. Motivated by celestiaorg/celestia-node#3569 Thanks @ramin!<hr>This is an automatic backport of pull request #3701 done by [Mergify](https://mergify.com). Co-authored-by: Rootul P <[email protected]>
rootulp
added a commit
to celestiaorg/celestia-app
that referenced
this pull request
Jul 18, 2024
…3703) There is an issue with goreleaser where it will automatically mark release candidates as the latest release. Motivated by celestiaorg/celestia-node#3569 Thanks @ramin!<hr>This is an automatic backport of pull request #3701 done by [Mergify](https://mergify.com). Co-authored-by: Rootul P <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes goreleaser.yml config to ensure that tags/releases are not automatically promoted to latest by adding the
release.prerelease = autoconfig (previously defaulted to false), also set a proper pre-release suffix for tag filtering etc. This allows us to create signed binaries for pre-releases/release candidates.Tested on a private branch and ensured that with
release.prerelease: autoreleases created in github and with the toggle "Set as a pre-release" set to true, goreleaser would NOT set them as latest upon publishing artifacts.