chore: Update docker-build-publish.yml #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSevey
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
|
sorry, syntax bug slipped through. Not sure why it didn't come up in my testing. Fix is here, celestiaorg/.github#78 Will do another release and update this PR. |
MSevey
commented
Oct 12, 2023
MSevey
commented
Oct 12, 2023
|
man this PR is giving me a run for my money haha |
Codecov Report
@@ Coverage Diff @@
## main #2838 +/- ##
==========================================
- Coverage 51.20% 50.87% -0.33%
==========================================
Files 168 168
Lines 10730 10730
==========================================
- Hits 5494 5459 -35
- Misses 4755 4790 +35
Partials 481 481 |
Wondertan
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes the bug that rollkit local-celestia-devent was experiencing with the docker images being overwritten.
The changes to the reuseable docker action simplify the logic for easier maintenance.
The changes to the node CI file are to only run the docker action on a PR or pushes to main. When the workflow was triggering on all push events, the action was running twice on PRs which was contributing to the confusion and causing images to be overwritten.
This means if the team wants a docker image built for testing, they must open at least a draft PR. The PR doesn't need to be merged, but the PR trigger is what will built the image.
Checklist