fix(share/peer-manager): use mutex for peer-manager pool cleanup #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
ramin
previously approved these changes
Oct 6, 2023
distractedm1nd
previously approved these changes
Oct 6, 2023
Wondertan
previously approved these changes
Oct 6, 2023
renaynay
previously approved these changes
Oct 6, 2023
walldiss
dismissed stale reviews from renaynay, Wondertan, distractedm1nd, and ramin
via
63f4e11
Codecov Report
@@ Coverage Diff @@
## main #2817 +/- ##
==========================================
- Coverage 51.44% 51.37% -0.07%
==========================================
Files 167 167
Lines 10752 10756 +4
==========================================
- Hits 5531 5526 -5
- Misses 4742 4749 +7
- Partials 479 481 +2
|
Wondertan
reviewed
Oct 6, 2023
Wondertan
approved these changes
Oct 6, 2023
distractedm1nd
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2807