Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve ErrNoStateAccess message #2752

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

distractedm1nd
Copy link
Collaborator

After getting the following response from the RPC

➜ celestia rpc state AccountAddress
{
  "jsonrpc": "2.0",
  "id": 1,
  "error": {
    "code": 1,
    "message": "node is running without state access"
  }
}

I realized it would be more helpful to tell users what they can do to resolve the issue. Knowing that the node needs to be passed --core.ip when you see "node is running without state access" is not something obvious

@distractedm1nd distractedm1nd added kind:fix Attached to bug-fixing PRs area:api Related to celestia-node API labels Sep 25, 2023
@distractedm1nd distractedm1nd self-assigned this Sep 25, 2023
@Wondertan
Copy link
Member

We recently discussed a different solution to this problem with @renaynay where we hardcode core.ip address per network so that users can run a fully functioning node with just init and start. After that, this error might be even removed. IIRC, @renaynay planned this for before mainnet.

@distractedm1nd
Copy link
Collaborator Author

That would 100% be better UX, as long as we can provide the infra for it :D

@ramin ramin self-requested a review September 25, 2023 08:20
@ramin
Copy link
Contributor

ramin commented Sep 25, 2023

this one got me the other day, nice

@distractedm1nd distractedm1nd merged commit 5e22259 into main Sep 25, 2023
18 of 20 checks passed
@distractedm1nd distractedm1nd deleted the improve-state-error-msg branch September 25, 2023 08:37
vgonkivs pushed a commit to vgonkivs/celestia-node that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Related to celestia-node API kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants