Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shrexeds): close stream #2705

Merged
merged 1 commit into from
Sep 14, 2023
Merged

fix(shrexeds): close stream #2705

merged 1 commit into from
Sep 14, 2023

Conversation

Wondertan
Copy link
Member

@Wondertan Wondertan commented Sep 14, 2023 •
edited
Loading

If we receive a valid StatusMessage, we only CoseWrite side of the stream, but the stream interface states:

	// CloseWrite closes the stream for writing but leaves it open for
	// reading.
	//
	// CloseWrite does not free the stream, users must still call Close or
	// Reset.
	CloseWrite() error

@Wondertan Wondertan added area:shares Shares and samples area:p2p labels Sep 14, 2023
@Wondertan Wondertan self-assigned this Sep 14, 2023
@Wondertan Wondertan added the kind:fix Attached to bug-fixing PRs label Sep 14, 2023
@Wondertan
Copy link
Member Author

Wondertan commented Sep 14, 2023 •
edited
Loading

I am surprised we missed this somehow and no clue why this didn't show up in profiles/metrics(probably because we focus on BN which does not run the client)

@Wondertan Wondertan enabled auto-merge (squash) September 14, 2023 16:23
@Wondertan Wondertan merged commit 7c1f8f3 into main Sep 14, 2023
17 of 20 checks passed
@Wondertan Wondertan deleted the hlib/shrexds/close-stream branch September 14, 2023 17:46
vgonkivs pushed a commit to vgonkivs/celestia-node that referenced this pull request Oct 5, 2023
@Wondertan @vgonkivs
fix(shrexeds): close stream (celestiaorg#2705)
52c847d
@faddat faddat mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walldiss walldiss walldiss approved these changes

@vgonkivs vgonkivs vgonkivs approved these changes

@renaynay renaynay renaynay approved these changes

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd

Assignees

@Wondertan Wondertan

Labels
area:p2p area:shares Shares and samples kind:fix Attached to bug-fixing PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Wondertan @walldiss @vgonkivs @renaynay