Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: bump celestia-app to v1.0.0-rc13 #2646

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented Aug 31, 2023

Overview

bumps app to v1.0.0-rc13, core to v1.26.2-tm-v0.34.28, the sdk to v1.18.0-sdk-v0.46.14, and nmt to v0.19.0

per release notes: this is a consensus breaking change that is targetting mocha-4 and arabica-10

besides the already mentioned changes, this bumps app to go 1.21 🎉 and has the simplified programmatic transaction signing repo (we got rid of the KeyringSigner since it was originally designed for tx malleation). This package can be found here, and there are a few (hopefully straightforward) examples here, here, and here. When you all are ready, we'd like to remove the KeyringSigner, and would be delighted to help migrate.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@evan-forbes evan-forbes added the kind:deps Pull requests that update a dependency file label Aug 31, 2023
@evan-forbes evan-forbes self-assigned this Aug 31, 2023
@github-actions github-actions bot added the external Issues created by non node team members label Aug 31, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2646 (e702308) into main (47047f3) will decrease coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2646      +/-   ##
==========================================
- Coverage   51.34%   51.05%   -0.29%     
==========================================
  Files         158      158              
  Lines       10559    10559              
==========================================
- Hits         5421     5391      -30     
- Misses       4669     4693      +24     
- Partials      469      475       +6     

see 7 files with indirect coverage changes

@evan-forbes evan-forbes removed the external Issues created by non node team members label Aug 31, 2023
go.mod Outdated Show resolved Hide resolved
@renaynay renaynay changed the title chore: bump celestia-app to v1.0.0-rc13 chore!: bump celestia-app to v1.0.0-rc13 Sep 4, 2023
@renaynay renaynay added the kind:break! Attached to breaking PRs label Sep 4, 2023
renaynay
renaynay previously approved these changes Sep 4, 2023
@Wondertan Wondertan merged commit 81d6d3b into main Sep 4, 2023
15 of 17 checks passed
@Wondertan Wondertan deleted the evan/bump-celestia-app-v1.0.0-rc13 branch September 4, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:break! Attached to breaking PRs kind:deps Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants