Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eds/store): add eds blockstore cache metrics #2567

Merged
merged 6 commits into from
Aug 18, 2023

Conversation

walldiss
Copy link
Member

Add metrics allowing to see blockstore cache size and eviction pressure

@walldiss walldiss added area:storage kind:feat Attached to feature PRs area:metrics Related to measuring/collecting node metrics labels Aug 15, 2023
@walldiss walldiss self-assigned this Aug 15, 2023
share/eds/store.go Outdated Show resolved Hide resolved
share/eds/accessor_cache.go Outdated Show resolved Hide resolved
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we only enable metrics inside blockstore cache if metrics are enabled for eds store?

@codecov-commenter
Copy link

Codecov Report

Merging #2567 (aa4c945) into main (003c2c4) will decrease coverage by 0.20%.
The diff coverage is 3.12%.

@@            Coverage Diff             @@
##             main    #2567      +/-   ##
==========================================
- Coverage   51.01%   50.81%   -0.20%     
==========================================
  Files         158      158              
  Lines       10398    10429      +31     
==========================================
- Hits         5305     5300       -5     
- Misses       4627     4663      +36     
  Partials      466      466              
Files Changed Coverage Δ
share/eds/accessor_cache.go 32.53% <0.00%> (-16.57%) ⬇️
share/eds/metrics.go 20.57% <0.00%> (-0.36%) ⬇️
share/eds/store.go 60.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Wondertan
Wondertan previously approved these changes Aug 16, 2023
share/eds/store.go Outdated Show resolved Hide resolved
renaynay
renaynay previously approved these changes Aug 16, 2023
@walldiss walldiss requested a review from renaynay August 16, 2023 16:23
@walldiss walldiss enabled auto-merge (squash) August 18, 2023 11:00
@walldiss walldiss merged commit 323f603 into celestiaorg:main Aug 18, 2023
12 of 14 checks passed
renaynay pushed a commit to renaynay/celestia-node that referenced this pull request Aug 23, 2023
Add metrics allowing to see blockstore cache size and eviction pressure
walldiss added a commit to walldiss/celestia-node that referenced this pull request Sep 22, 2023
Add metrics allowing to see blockstore cache size and eviction pressure

(cherry picked from commit 323f603)
walldiss added a commit that referenced this pull request Sep 22, 2023
Add metrics allowing to see blockstore cache size and eviction pressure

(cherry picked from commit 323f603)
walldiss added a commit to walldiss/celestia-node that referenced this pull request Sep 22, 2023
Add metrics allowing to see blockstore cache size and eviction pressure

(cherry picked from commit 323f603)
walldiss added a commit to walldiss/celestia-node that referenced this pull request Sep 25, 2023
Add metrics allowing to see blockstore cache size and eviction pressure

(cherry picked from commit 323f603)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Related to measuring/collecting node metrics area:storage kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants