-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eds/store): add eds blockstore cache metrics #2567
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
added
area:storage
kind:feat
Attached to feature PRs
area:metrics
Related to measuring/collecting node metrics
labels
Aug 15, 2023
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
August 15, 2023 06:30
Wondertan
reviewed
Aug 15, 2023
renaynay
reviewed
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we only enable metrics inside blockstore cache if metrics are enabled for eds store?
walldiss
force-pushed
the
blockstore-cache-metrics
branch
from
August 15, 2023 15:55
44aa4fa
to
aa4c945
Compare
Codecov Report
@@ Coverage Diff @@
## main #2567 +/- ##
==========================================
- Coverage 51.01% 50.81% -0.20%
==========================================
Files 158 158
Lines 10398 10429 +31
==========================================
- Hits 5305 5300 -5
- Misses 4627 4663 +36
Partials 466 466
|
Wondertan
previously approved these changes
Aug 16, 2023
renaynay
reviewed
Aug 16, 2023
Wondertan
reviewed
Aug 16, 2023
renaynay
previously approved these changes
Aug 16, 2023
Wondertan
approved these changes
Aug 16, 2023
distractedm1nd
approved these changes
Aug 18, 2023
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Aug 23, 2023
Add metrics allowing to see blockstore cache size and eviction pressure
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 22, 2023
Add metrics allowing to see blockstore cache size and eviction pressure (cherry picked from commit 323f603)
walldiss
added a commit
that referenced
this pull request
Sep 22, 2023
Add metrics allowing to see blockstore cache size and eviction pressure (cherry picked from commit 323f603)
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 22, 2023
Add metrics allowing to see blockstore cache size and eviction pressure (cherry picked from commit 323f603)
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 25, 2023
Add metrics allowing to see blockstore cache size and eviction pressure (cherry picked from commit 323f603)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:metrics
Related to measuring/collecting node metrics
area:storage
kind:feat
Attached to feature PRs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add metrics allowing to see blockstore cache size and eviction pressure