Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd): fix formatting during submit #2551

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Aug 9, 2023

Overview

As we expect direct types every time, I would suggest skipping error handling in case of format data(and simply return data if casting fails). I think this is the best way to keep logic generic and avoid any additional bool flags, options etc.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs added area:rpc kind:fix Attached to bug-fixing PRs labels Aug 9, 2023
@vgonkivs vgonkivs requested a review from jcstein August 9, 2023 20:29
@vgonkivs vgonkivs self-assigned this Aug 9, 2023
Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me as expected

celestia rpc blob submit 0x42690c204d39600fddd3 'gm'
{
  "result": {
    "uint64": 232874,
    "commitment": "IXg+08HV5RsPF3Lle8PH+B2TUGsGUsBiseflxh6wB5E="
  }
}

@codecov-commenter
Copy link

Codecov Report

Merging #2551 (8a69fa1) into main (94a6b63) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2551      +/-   ##
==========================================
+ Coverage   51.08%   51.10%   +0.01%     
==========================================
  Files         158      158              
  Lines       10403    10401       -2     
==========================================
+ Hits         5314     5315       +1     
+ Misses       4626     4620       -6     
- Partials      463      466       +3     
Files Changed Coverage Δ
cmd/celestia/blob.go 9.93% <0.00%> (+0.12%) ⬆️

... and 6 files with indirect coverage changes

@vgonkivs vgonkivs merged commit 426c337 into celestiaorg:main Aug 10, 2023
13 of 15 checks passed
renaynay pushed a commit to renaynay/celestia-node that referenced this pull request Aug 23, 2023
walldiss pushed a commit to walldiss/celestia-node that referenced this pull request Sep 22, 2023
walldiss pushed a commit that referenced this pull request Sep 22, 2023
walldiss pushed a commit to walldiss/celestia-node that referenced this pull request Sep 22, 2023
walldiss pushed a commit to walldiss/celestia-node that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rpc kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants