Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nodebuilder/p2p)! Upgrade to mocha-3 #2432

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

sysrex
Copy link
Contributor

@sysrex sysrex commented Jul 5, 2023

Overview

Update to mocha-3 chain name when init is called.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@github-actions github-actions bot added the external Issues created by non node team members label Jul 5, 2023
@renaynay renaynay changed the title changed the mocha-2 network chore(nodebuilder/p2p)! Upgrade to mocha-3 Jul 5, 2023
@renaynay renaynay added the kind:break! Attached to breaking PRs label Jul 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

Merging #2432 (4e61b12) into main (beaf6db) will decrease coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2432      +/-   ##
==========================================
- Coverage   53.28%   53.10%   -0.19%     
==========================================
  Files         156      156              
  Lines        9915     9915              
==========================================
- Hits         5283     5265      -18     
- Misses       4179     4196      +17     
- Partials      453      454       +1     
Impacted Files Coverage Δ
nodebuilder/p2p/genesis.go 0.00% <ø> (ø)
nodebuilder/p2p/network.go 57.89% <ø> (ø)

... and 5 files with indirect coverage changes

@jcstein
Copy link
Member

jcstein commented Jul 5, 2023

does the bootstrap list also need to be updated?

Mocha: {
"/dns4/bootstr-mocha-1.celestia-mocha.com/tcp/2121/p2p/12D3KooWDRSJMbH3PS4dRDa11H7Tk615aqTUgkeEKz4pwd4sS6fN",
"/dns4/bootstr-mocha-2.celestia-mocha.com/tcp/2121/p2p/12D3KooWEk7cxtjQCC7kC84Uhs2j6dAHjdbwYnPcvUAqmj6Zsry2",
"/dns4/bootstr-mocha-3.celestia-mocha.com/tcp/2121/p2p/12D3KooWBE4QcFXZzENf2VRo6Y5LBvp9gzmpYRHKCvgGzEYj7Hdn",
},

@jcstein
Copy link
Member

jcstein commented Jul 5, 2023

@sysrex
Copy link
Contributor Author

sysrex commented Jul 5, 2023

does the bootstrap list also need to be updated?

Mocha: {
"/dns4/bootstr-mocha-1.celestia-mocha.com/tcp/2121/p2p/12D3KooWDRSJMbH3PS4dRDa11H7Tk615aqTUgkeEKz4pwd4sS6fN",
"/dns4/bootstr-mocha-2.celestia-mocha.com/tcp/2121/p2p/12D3KooWEk7cxtjQCC7kC84Uhs2j6dAHjdbwYnPcvUAqmj6Zsry2",
"/dns4/bootstr-mocha-3.celestia-mocha.com/tcp/2121/p2p/12D3KooWBE4QcFXZzENf2VRo6Y5LBvp9gzmpYRHKCvgGzEYj7Hdn",
},

the multiaddress and the dns records are exactly the same, no update is required.

@Wondertan Wondertan added this pull request to the merge queue Jul 5, 2023
Merged via the queue into celestiaorg:main with commit 0d10ced Jul 5, 2023
@sysrex sysrex deleted the sysrex/updates_to_mocha3 branch July 24, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members kind:break! Attached to breaking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants