-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
share/befp: rework collecting and verifying the BEFP #2408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
added
area:shares
Shares and samples
kind:misc
Attached to miscellaneous PRs
labels
Jun 28, 2023
vgonkivs
force-pushed
the
rework_befp_validation
branch
from
July 4, 2023 09:50
2df2150
to
f09539f
Compare
vgonkivs
requested review from
renaynay,
Wondertan,
distractedm1nd and
walldiss
as code owners
July 4, 2023 09:51
Codecov Report
@@ Coverage Diff @@
## main #2408 +/- ##
==========================================
- Coverage 53.25% 53.05% -0.20%
==========================================
Files 156 156
Lines 9915 9946 +31
==========================================
- Hits 5280 5277 -3
- Misses 4180 4211 +31
- Partials 455 458 +3
|
vgonkivs
force-pushed
the
rework_befp_validation
branch
2 times, most recently
from
July 4, 2023 11:12
3a66578
to
6e5b6bb
Compare
Wondertan
reviewed
Jul 4, 2023
adlerjohn
changed the title
share/befp: rework collecting and veryfying the BEFP
share/befp: rework collecting and verifying the BEFP
Jul 4, 2023
walldiss
reviewed
Jul 5, 2023
renaynay
reviewed
Jul 6, 2023
Co-authored-by: Hlib Kanunnikov <[email protected]>
vgonkivs
force-pushed
the
rework_befp_validation
branch
from
July 6, 2023 12:59
7c908fd
to
d8ce446
Compare
Wondertan
previously approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
renaynay
previously approved these changes
Jul 11, 2023
renaynay
approved these changes
Jul 11, 2023
Wondertan
approved these changes
Jul 11, 2023
adlerjohn
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok.
walldiss
approved these changes
Jul 11, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Jul 11, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Checklist