-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gateway): enabling CORS * on gateway #2373
Conversation
What about RPC? Did we check if it allows all the origins? The link we had was just for WS |
@Wondertan I have not checked http over rpc, but the default connection for RPC should be ws://localhost anyways - since its the only transport that supports all of our endpoints. Adding in CORS for the (default) http client is pretty trivial but adds a lot of code (we are then no longer using the default http client so have to copy the rest of the default configuration to our client code) |
My worry here comes from @smuu stating that RPC still didn't work because of CORS. Maybe because they used http and not ws? |
I think we used HTTP, yes. I don't know why we didn't try ws. |
Likely because it not obvious, nor it's documented anywhere |
Closes #2263