Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway): enabling CORS * on gateway #2373

Merged
merged 4 commits into from
Jun 21, 2023
Merged

feat(gateway): enabling CORS * on gateway #2373

merged 4 commits into from
Jun 21, 2023

Conversation

distractedm1nd
Copy link
Collaborator

Closes #2263

@distractedm1nd distractedm1nd added kind:feat Attached to feature PRs area:gateway Related to the node's gateway labels Jun 16, 2023
@distractedm1nd distractedm1nd self-assigned this Jun 16, 2023
@Wondertan
Copy link
Member

What about RPC? Did we check if it allows all the origins? The link we had was just for WS

@distractedm1nd
Copy link
Collaborator Author

@Wondertan I have not checked http over rpc, but the default connection for RPC should be ws://localhost anyways - since its the only transport that supports all of our endpoints. Adding in CORS for the (default) http client is pretty trivial but adds a lot of code (we are then no longer using the default http client so have to copy the rest of the default configuration to our client code)

@Wondertan
Copy link
Member

My worry here comes from @smuu stating that RPC still didn't work because of CORS. Maybe because they used http and not ws?

@smuu
Copy link
Member

smuu commented Jun 19, 2023

My worry here comes from @smuu stating that RPC still didn't work because of CORS. Maybe because they used http and not ws?

I think we used HTTP, yes. I don't know why we didn't try ws.

@Wondertan
Copy link
Member

I think we used HTTP, yes. I don't know why we didn't try was.

Likely because it not obvious, nor it's documented anywhere

@Wondertan Wondertan enabled auto-merge June 21, 2023 14:46
@Wondertan Wondertan added this pull request to the merge queue Jun 21, 2023
@Wondertan Wondertan removed this pull request from the merge queue due to a manual request Jun 21, 2023
@Wondertan Wondertan enabled auto-merge June 21, 2023 15:22
@Wondertan Wondertan added this pull request to the merge queue Jun 21, 2023
Merged via the queue into main with commit de88cff Jun 21, 2023
@Wondertan Wondertan deleted the gateway-cors branch June 21, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:gateway Related to the node's gateway kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants