Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump celestia-app rc4 #2371

Merged
merged 5 commits into from
Jun 21, 2023
Merged

chore: bump celestia-app rc4 #2371

merged 5 commits into from
Jun 21, 2023

Conversation

evan-forbes
Copy link
Member

Overview

I'm getting a failed unit test, TestBlobModule, locally but I'm also getting that on main

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@github-actions github-actions bot added the external Issues created by non node team members label Jun 15, 2023
Wondertan
Wondertan previously approved these changes Jun 15, 2023
View reviewed changes
go.mod Show resolved Hide resolved
@evan-forbes evan-forbes added kind:deps Pull requests that update a dependency file and removed external Issues created by non node team members labels Jun 15, 2023
@evan-forbes evan-forbes self-assigned this Jun 15, 2023
Wondertan
Wondertan previously approved these changes Jun 15, 2023
View reviewed changes
@Wondertan
Copy link
Member

The test became flaky recently and will be fixed by #2256

renaynay
renaynay previously approved these changes Jun 21, 2023
View reviewed changes
@Wondertan Wondertan added this pull request to the merge queue Jun 21, 2023
@Wondertan Wondertan removed this pull request from the merge queue due to a manual request Jun 21, 2023
@Wondertan Wondertan enabled auto-merge June 21, 2023 15:23
@Wondertan Wondertan added this pull request to the merge queue Jun 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jun 21, 2023
@Wondertan Wondertan dismissed stale reviews from renaynay and themself via 759ad53 June 21, 2023 15:39
@Wondertan Wondertan enabled auto-merge June 21, 2023 16:09
@Wondertan Wondertan added this pull request to the merge queue Jun 21, 2023
Merged via the queue into celestiaorg:main with commit b222475 Jun 21, 2023
@Wondertan Wondertan deleted the evan/bump-app-rc4 branch June 21, 2023 16:17
@faddat faddat mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan left review comments

@adlerjohn adlerjohn adlerjohn approved these changes

@vgonkivs vgonkivs vgonkivs approved these changes

@renaynay renaynay renaynay left review comments

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees

@evan-forbes evan-forbes

Labels
kind:deps Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@evan-forbes @Wondertan @adlerjohn @vgonkivs @renaynay