Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mocha-2 support #2326

Merged
merged 6 commits into from
Jun 13, 2023
Merged

Conversation

evan-forbes
Copy link
Member

Overview

note that we're skipping mocha-1 because we reset the network after finding a state breaking bug friday

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@evan-forbes evan-forbes self-assigned this Jun 5, 2023
@github-actions github-actions bot added the external Issues created by non node team members label Jun 5, 2023
@evan-forbes evan-forbes added kind:misc Attached to miscellaneous PRs kind:chore and removed external Issues created by non node team members kind:misc Attached to miscellaneous PRs labels Jun 5, 2023
@Wondertan
Copy link
Member

Wondertan commented Jun 6, 2023

We should also include updated genesis-hash and update bootstrappers here

cc @Bidon15

@Bidon15
Copy link
Member

Bidon15 commented Jun 6, 2023

We should also include updated genesis-hash and update bootstrappers here

cc @Bidon15

Thanks for flagging this!
After @sysrex deploys bootstrappers -> we will do a separate PR for this 👍

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Merging #2326 (9c50b74) into main (dd1a019) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2326      +/-   ##
==========================================
- Coverage   50.66%   50.56%   -0.11%     
==========================================
  Files         154      154              
  Lines        9736     9736              
==========================================
- Hits         4933     4923      -10     
- Misses       4378     4386       +8     
- Partials      425      427       +2     
Impacted Files Coverage Δ
nodebuilder/p2p/genesis.go 0.00% <ø> (ø)
nodebuilder/p2p/network.go 57.89% <ø> (ø)

... and 4 files with indirect coverage changes

@evan-forbes
Copy link
Member Author

cool, just updated with the genesis hash, do we still want to merge this?

@Wondertan
Copy link
Member

We need to have confirmation from @Bidon15 that addresses of bootstrappers didn't change, but if so we should also update them here or in different PR(better here)

@Wondertan Wondertan changed the title chore!: increment mocha's chain id chore: mocha-2 support Jun 8, 2023
@Wondertan Wondertan enabled auto-merge (squash) June 8, 2023 15:23
@Bidon15
Copy link
Member

Bidon15 commented Jun 9, 2023

bootstrapper names are the same, so we can safely merge this PR @Wondertan

@Wondertan
Copy link
Member

@Bidon15, wdym? @sysrex sent us new addresses and @evan-forbes update the PR with them

@Bidon15
Copy link
Member

Bidon15 commented Jun 9, 2023

@Bidon15, wdym? @sysrex sent us new addresses and @evan-forbes update the PR with them

Oh my bad. I didn't look at the day of the question and thought that if there are even newer addresses comparing to these ones

"/dns4/bootstr-mocha-1.celestia-mocha.com/tcp/2121/p2p/12D3KooWDRSJMbH3PS4dRDa11H7Tk615aqTUgkeEKz4pwd4sS6fN",

"/dns4/bootstr-mocha-2.celestia-mocha.com/tcp/2121/p2p/12D3KooWEk7cxtjQCC7kC84Uhs2j6dAHjdbwYnPcvUAqmj6Zsry2",

"/dns4/bootstr-mocha-3.celestia-mocha.com/tcp/2121/p2p/12D3KooWBE4QcFXZzENf2VRo6Y5LBvp9gzmpYRHKCvgGzEYj7Hdn",

@Wondertan Wondertan merged commit c9443c6 into celestiaorg:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants