Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: bump app v1.0.0-rc0 #2253

Merged
merged 51 commits into from
May 29, 2023
Merged

feat!: bump app v1.0.0-rc0 #2253

merged 51 commits into from
May 29, 2023

Conversation

evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented May 25, 2023 •
edited
Loading

Overview

bumps app to v1.0.0-rc0

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rootulp
chore!: bump to celestia-app v0.14.0-rc0
3295453
@rootulp
fix tests
a135598
@rootulp
wip: mark tests that need fixing
769f48e
@rootulp
wip: debug TestService_GetSharesByNamespace
647c90e
@rootulp
celestia-node depends on ignoreMaxNs
3382a47
@rootulp
chore: remove 8 from sha256Namespace8Flagged
2af019a
@rootulp
fix: TestService_GetSharesByNamespace
56f2ff5
@rootulp
feat: verifyAny row root
4a4be1c
@rootulp
revert: getter.go b/c modifying celestia-app parity namespace
c0cfc7f
@rootulp
revert: unnecessary changes b/c parity namespace id in celestia-app
f515546
@rootulp
fix TestSharesRoundTrip
e81ed85
@rootulp
fix: TestQuadrantOrder
62ab0d4
@rootulp
fix: TestReadEDS
4460faa 
by regenerating testdata b/c roots are longer
@rootulp
Merge branch 'main' into rp/bump-celestia-app
0e988cf
@rootulp
chore: prefer crypto/rand over math/rand
551b0da
@rootulp
chore: upgrade to celestia-app v0.14.0-rc2
f3b5d9f
@rootulp
Merge branch 'main' into rp/bump-celestia-app
d9a573c
@rootulp
fix comment
0a9c80c
@rootulp
fix: lint
f934f9e
@rootulp
Merge branch 'main' into rp/bump-celestia-app
24d253e
@rootulp
fix: TestShrexGetter
23a611d
@rootulp
fix: GetSharesByNamespace
0b37134
@rootulp
fix: TestExchange_RequestND_NotFound
d3a6243
@rootulp
fix: TestStoreGetter
2e1e5ce
@rootulp
fix: TestService_GetSharesByNamespace
9cee800 
remove test b/c it seems duplicative of
TestService_GetSharesByNamespaceNotFound
@rootulp
fix: TestRetriever_ByzantineError
c505103
@rootulp
chore: address @Wondertan feedback
df4d5f1
@rootulp
Merge branch 'main' into rp/bump-celestia-app
18117b7
@rootulp
Merge branch 'main' into rp/bump-celestia-app
ed41784
@rootulp
chore: upgrade to celestia-app v0.15.0-rc0
4f3e0ee
evan-forbes
evan-forbes commented May 25, 2023
View reviewed changes
api/gateway/share_test.go Outdated Show resolved Hide resolved
core/eds_test.go Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
share/availability/light/availability_test.go Show resolved Hide resolved
share/eds/eds_test.go Show resolved Hide resolved
@evan-forbes
Copy link
Member Author

all tests are passing locally for me, can others pls double check?

renaynay
renaynay reviewed May 25, 2023
View reviewed changes
core/eds.go Show resolved Hide resolved
core/eds_test.go Show resolved Hide resolved
share/availability/light/availability_test.go Show resolved Hide resolved
share/availability/light/availability_test.go Show resolved Hide resolved
share/eds/eds_test.go Outdated Show resolved Hide resolved
@evan-forbes evan-forbes mentioned this pull request May 25, 2023
Closed
rootulp
rootulp previously approved these changes May 25, 2023
View reviewed changes
api/gateway/share_test.go Outdated Show resolved Hide resolved
core/eds_test.go Outdated Show resolved Hide resolved
core/eds_test.go Outdated Show resolved Hide resolved
Wondertan
Wondertan reviewed May 26, 2023
View reviewed changes
go.mod Show resolved Hide resolved
api/gateway/share_test.go Outdated Show resolved Hide resolved
core/eds_test.go Show resolved Hide resolved
core/eds.go Show resolved Hide resolved
share/eds/eds.go Outdated Show resolved Hide resolved
share/eds/eds.go Outdated Show resolved Hide resolved
share/eds/eds_test.go Outdated Show resolved Hide resolved
@Wondertan Wondertan mentioned this pull request May 29, 2023
Open
Wondertan
Wondertan approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rootulp and @evan-forbes

@Wondertan Wondertan enabled auto-merge (squash) May 29, 2023 09:09
@Wondertan Wondertan merged commit 9359b65 into celestiaorg:main May 29, 2023
@adlerjohn adlerjohn mentioned this pull request Jun 28, 2023
Closed
5 tasks
@faddat faddat mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@distractedm1nd distractedm1nd distractedm1nd approved these changes

@Wondertan Wondertan Wondertan approved these changes

@vgonkivs vgonkivs vgonkivs approved these changes

@renaynay renaynay renaynay approved these changes

@rootulp rootulp rootulp left review comments

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees
No one assigned
Labels
kind:deps Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@evan-forbes @codecov-commenter @rootulp @distractedm1nd @Wondertan @vgonkivs @renaynay