Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(share/shrex/nd): add swamp test for shrex nd #2227

Merged
merged 8 commits into from
Aug 1, 2023

Conversation

walldiss
Copy link
Member

@walldiss walldiss commented May 18, 2023

Overview

Feel free to suggest more test cases if you have any ideas

Closes #2119

@walldiss walldiss added area:shares Shares and samples kind:feat Attached to feature PRs labels May 18, 2023
@walldiss walldiss requested a review from renaynay as a code owner May 18, 2023 11:47
@walldiss walldiss self-assigned this May 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Merging #2227 (3d0a819) into main (eaa5835) will decrease coverage by 0.51%.
Report is 24 commits behind head on main.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main    #2227      +/-   ##
==========================================
- Coverage   53.12%   52.61%   -0.51%     
==========================================
  Files         156      156              
  Lines        9907    10002      +95     
==========================================
  Hits         5263     5263              
- Misses       4188     4274      +86     
- Partials      456      465       +9     
Files Changed Coverage Δ
share/p2p/shrexnd/server.go 52.94% <71.42%> (-0.08%) ⬇️

... and 32 files with indirect coverage changes

nodebuilder/tests/nd_test.go Outdated Show resolved Hide resolved
nodebuilder/tests/nd_test.go Outdated Show resolved Hide resolved
share/p2p/shrexnd/server.go Show resolved Hide resolved
@Bidon15
Copy link
Member

Bidon15 commented May 25, 2023

Fantastic PR @walldiss 🚀

I believe you can close this issue #2119 with this PR

Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walldiss let's convert this to draft / just wait until cleanussy is merged so tht you can follow the new cleanussy pattern and rely on some cleaner endpoints i have

nodebuilder/share/config.go Outdated Show resolved Hide resolved
nodebuilder/share/constructors.go Outdated Show resolved Hide resolved
nodebuilder/tests/nd_test.go Outdated Show resolved Hide resolved
@walldiss walldiss marked this pull request as draft May 29, 2023 09:42
@walldiss walldiss marked this pull request as ready for review July 7, 2023 16:22
@renaynay
Copy link
Member

During a random run of TestShrexNDFromLightsWithBadFulls, got this fatal:

2023-07-31T14:43:18.569+0200	DEBUG	share/getters	getters/cascade.go:115	cascade: launching getter #0
2023-07-31T14:43:18.570+0200	ERROR	ipld	ipld/namespace_data.go:247	could not retrieve IPLD node	{"namespace": "00000000000000000000000000000000000000186d38b0311dc2a45a12", "pos": 0, "err": "nmt node not found"}
2023-07-31T14:43:18.570+0200	ERROR	ipld	ipld/namespace_data.go:247	could not retrieve IPLD node	{"namespace": "00000000000000000000000000000000000000186d38b0311dc2a45a12", "pos": 0, "err": "nmt node not found"}
2023-07-31T14:43:18.570+0200	ERROR	ipld	ipld/namespace_data.go:247	could not retrieve IPLD node	{"namespace": "00000000000000000000000000000000000000186d38b0311dc2a45a12", "pos": 1, "err": "nmt node not found"}
2023-07-31T14:43:18.570+0200	ERROR	ipld	ipld/namespace_data.go:247	could not retrieve IPLD node	{"namespace": "00000000000000000000000000000000000000186d38b0311dc2a45a12", "pos": 0, "err": "nmt node not found"}
2023-07-31T14:43:18.570+0200	FATAL	ipld	ipld/namespace_data.go:305	target namespace outside of boundaries of links at depth: 3

nodebuilder/tests/nd_test.go Outdated Show resolved Hide resolved
@walldiss walldiss enabled auto-merge (squash) August 1, 2023 12:21
@walldiss walldiss merged commit 08ffb69 into celestiaorg:main Aug 1, 2023
12 of 14 checks passed
walldiss added a commit to walldiss/celestia-node that referenced this pull request Aug 4, 2023
walldiss added a commit to walldiss/celestia-node that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:shares Shares and samples kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testing/integration: implement shrex suite
6 participants