feat(statesync): add app version to snapshot #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
requested review from
cmwaters,
evan-forbes,
staheri14,
rach-id and
ninabarbakadze
and removed request for
a team
evan-forbes
approved these changes
Sep 30, 2024
rach-id
reviewed
Sep 30, 2024
Comment on lines
+37
to
+39
| stateProvider.On("State", mock.AnythingOfType("*context.timerCtx"), uint64(1)).Return(sm.State{}, nil) | ||
| stateProvider.On("State", mock.AnythingOfType("*context.timerCtx"), uint64(2)).Return(sm.State{}, nil) | ||
| stateProvider.On("State", mock.AnythingOfType("*context.timerCtx"), uint64(4)).Return(sm.State{}, nil) |
There was a problem hiding this comment.
why is this being called three times? if I understand correctly, only the uint64(4) will be provided, no?
There was a problem hiding this comment.
IIRC the test calls it a few times with different block heights.
rach-id
approved these changes
Sep 30, 2024
rootulp
added a commit
to celestiaorg/celestia-app
that referenced
this pull request
Oct 2, 2024
Closes #3818 ~~Blocked on celestiaorg/celestia-core#1477 I had to bump the celestia-core depedency to get a feature that I wanted. That implied upgrading Go and cosmos-sdk versions. ## Testing I verified that logs added in this PR show up when state syncing on Mocha. The logs show that the app version provided in the `OfferSnapshot` ABCI method was plumbed through correctly. ``` ./scripts/mocha.sh ... 2:44PM INF Offering snapshot to ABCI app format=2 hash="$�ڢ�\x1b� �zΊ\x15���`��왹\b^G:\x03+ߢޯ" height=2782000 module=statesync 2:44PM INF offering snapshot app_version=2 height=2782000 2:44PM INF mounting keys for snapshot app_version=2 ```
mergify bot
pushed a commit
to celestiaorg/celestia-app
that referenced
this pull request
Oct 2, 2024
Closes #3818 ~~Blocked on celestiaorg/celestia-core#1477 I had to bump the celestia-core depedency to get a feature that I wanted. That implied upgrading Go and cosmos-sdk versions. ## Testing I verified that logs added in this PR show up when state syncing on Mocha. The logs show that the app version provided in the `OfferSnapshot` ABCI method was plumbed through correctly. ``` ./scripts/mocha.sh ... 2:44PM INF Offering snapshot to ABCI app format=2 hash="$�ڢ�\x1b� �zΊ\x15���`��왹\b^G:\x03+ߢޯ" height=2782000 module=statesync 2:44PM INF offering snapshot app_version=2 height=2782000 2:44PM INF mounting keys for snapshot app_version=2 ``` (cherry picked from commit 73793b9) # Conflicts: # .github/workflows/lint.yml # Makefile # docker/txsim/Dockerfile # go.mod # go.sum
rootulp
added a commit
to celestiaorg/celestia-app
that referenced
this pull request
Oct 4, 2024
…3936) Closes #3818 ~~Blocked on celestiaorg/celestia-core#1477 I had to bump the celestia-core depedency to get a feature that I wanted. That implied upgrading Go and cosmos-sdk versions. ## Testing I verified that logs added in this PR show up when state syncing on Mocha. The logs show that the app version provided in the `OfferSnapshot` ABCI method was plumbed through correctly. ``` ./scripts/mocha.sh ... 2:44PM INF Offering snapshot to ABCI app format=2 hash="$�ڢ�\x1b� �zΊ\x15���`��왹\b^G:\x03+ߢޯ" height=2782000 module=statesync 2:44PM INF offering snapshot app_version=2 height=2782000 2:44PM INF mounting keys for snapshot app_version=2 ```<hr>This is an automatic backport of pull request #3871 done by [Mergify](https://mergify.com). --------- Co-authored-by: Rootul P <[email protected]>
rach-id
pushed a commit
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of celestiaorg/celestia-app#3818