-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix link #1472
docs: fix link #1472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to upstream this change
Could you elaborate so that I can make the changes? @rach-id |
Rachid was trying to convey that instead of this PR, you could make a similar PR to https://github.com/cometbft/cometbft with this diff. After it gets merged there, we can pull the change into this repo. I'm not strongly for or against this PR. I updated the PR title to conform to conventional commits in case we do merge it. |
WOW thanks for the advice. Will tried it later. |
Co-authored-by: CHAMI Rachid <[email protected]>
@animeherox thanks for helping with this. If you have time, you can also check this: celestiaorg/celestia-app#3885 :D |
Will take a look now 🔥 |
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Celestia Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
I found that the previous link is expired due to the structure change. dedf0d2#diff-f281ecc03994c15559193760bfdc29b0e4c448bf2abada106131842838931549 Updated it with hash in case it missing again. --------- Co-authored-by: CHAMI Rachid <[email protected]>
I found that the previous link is expired due to the structure change. dedf0d2#diff-f281ecc03994c15559193760bfdc29b0e4c448bf2abada106131842838931549
Updated it with hash in case it missing again.