chore: remove maverick directory #1465
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmwaters
requested review from
staheri14 and
ninabarbakadze
and removed request for
a team
|
I'm definitely in favor of removing it, but don't we still use it in the e2e test for validator-01? |
rootulp
approved these changes
Sep 5, 2024
evan-forbes
approved these changes
Sep 5, 2024
There was a different form of test added to the e2e tests later on. I can also port that across |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added to test double signing in the e2e tests. It was later removed in place of a simpler solution. Having this here means all changes to the consensus reactor and state need to be updated here. This PR removes it